fix: make Strings in meta backwards compatible
#4438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elsirion
commented
Feb 29, 2024
Comment on lines
+216
to
+221
| let string_ret = Box::new(str_value.clone()); | ||
| let ret: Box<V> = unsafe { | ||
| // We can transmute a String to V because we know that V==String | ||
| std::mem::transmute(string_ret) | ||
| }; | ||
| Ok(Some(*ret)) |
There was a problem hiding this comment.
I wasn't able to do this with a plain V, the compiler complained about unknown size, this seemed like the easiest fix.
There was a problem hiding this comment.
(@dpc used a similar unsafe trick elsewhere iirc, it's not new)
elsirion
force-pushed
the
2024-02-forgiving-meta
branch
from
4ad6edc
to
20db0a3
Compare
dpc
reviewed
Feb 29, 2024
| let string_ret = Box::new(str_value.clone()); | ||
| let ret: Box<V> = unsafe { | ||
| // We can transmute a String to V because we know that V==String | ||
| std::mem::transmute(string_ret) |
There was a problem hiding this comment.
Putting bounds here explicitly would make paranoid people feel a bit better about it.
dpc
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a long time we allowed plain strings in meta fields, i.e. without some ugly additional JSON quotation, but removed that bug/feature. Turns out that's a backwards incompatible change.
Related to #3648, #3699, #4432 and #4434.