feat: helper for canceling a future on task group shutdown #4457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maan2003
force-pushed
the
push-mozlnywzxqur
branch
from
e4692ff
to
3949093
Compare
|
how do you feel about clippy error, to me feels like we should disable that lint |
It seems to me it has a point, because when matching that clippy error with the diff, I wasn't sure where is the |
dpc
previously approved these changes
Mar 4, 2024
maan2003
force-pushed
the
push-mozlnywzxqur
branch
from
3949093
to
38e822d
Compare
|
satisfied clippy |
justinmoon
approved these changes
Mar 5, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.