include wasm-test.sh in test-ci-all (almost) #4474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpc
force-pushed
the
24-02-20-run-test-in-ci-all
branch
from
69ab8ce
to
9f36a10
Compare
|
Any idea why this test might be failing now? It seems like it hangs and timeout kills it. The same thing happens locally on my machine, so I doubt it's running out of resources. uses the same method and works perfectly. Seems like two rust tests in that hanged wasm-test are actualy passing so everything looks like it's working. |
|
very weird I have no idea why it would hang |
dpc
force-pushed
the
24-02-20-run-test-in-ci-all
branch
from
9f36a10
to
65c72c2
Compare
dpc
changed the title
dpc
force-pushed
the
24-02-20-run-test-in-ci-all
branch
from
65c72c2
to
d70a081
Compare
elsirion
reviewed
Mar 7, 2024
Yeah, I want these two separately because I want to be able to revert it when time comes to try again. It's a workaround for a blocker, ideally it would not be there at all. :( |
maan2003
approved these changes
Mar 8, 2024
dpc
force-pushed
the
24-02-20-run-test-in-ci-all
branch
from
d70a081
to
ca9bf08
Compare
Kodylow
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This required:
Unfortunately after tackling all the scripts & Nix issues, it turned out that wasm-tests (headless firefox?) just doesn't work when being run in GNU
parallelorxargs -P, and debugging it seems like lots of work.So we'll still run wasm-test separately, but at least it will now re-use build artifacts with the main build, so it should still be faster. And in the future we can try again.