fix: wrong git version hash calculated if source dirty #4483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradleystachurski
approved these changes
Mar 6, 2024
maan2003
reviewed
Mar 6, 2024
| @@ -66,7 +66,7 @@ fn set_code_version_inner() -> Result<(), String> { | |||
| // state by replacing the middle with 0s. This should | |||
| // be noticeable enough, while letting find out the | |||
| // root commit anyway. | |||
| format!("{}00000000{}", &hash[0..16], &hash[26..40]) | |||
| format!("{}00000000{}", &hash[0..16], &hash[(40 - 16)..40]) | |||
There was a problem hiding this comment.
maybe 16+8 instead of 40 - 16
There was a problem hiding this comment.
Yeah, I agree this would be easier to reason about at a glance if it were
[0..16], [(16+8)..40]
or even
let zeros_count = 8;
format!(
"{}{}{}",
&hash[0..16],
"0".repeat(zeros_count),
&hash[(16 + zeros_count)..40]
)
There was a problem hiding this comment.
The damage is done, no need to overthink it. When it was as a constant (incorrect at at) no one worried; now that it isn't (and actually gives the correct value), there's 10 ways to express it so bikesheding starts. :D
Just hit the green button :D
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mathz are hard.
Hey, at least it's not off by 1.