refactor(client): remove manual client arc counting #4484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpc
force-pushed
the
24-03-06-fix-client-shutdown-2
branch
3 times, most recently
from
85223bf
to
aa30514
Compare
elsirion
previously approved these changes
Mar 7, 2024
Fundamentally we can't rely on database count to detect when client executors (state machines and recoveries) finished, because external user might hold some references too. Also, we must not be dropping `inner : Arc<Client>` before we ensure executors stopped, because something running in them might still require that `Arc<Client>` is alive and weak references to them can be upgraded. Instead use the old and (somewhat) trusted TaskGroup to do the job.
dpc
force-pushed
the
24-03-06-fix-client-shutdown-2
branch
from
aa30514
to
d068ad5
Compare
Use two levels of `Arc` instead. While at it, rename and document things better.
dpc
force-pushed
the
24-03-06-fix-client-shutdown-2
branch
from
d068ad5
to
3f4f585
Compare
Fixed at first, but then decided to squash the 3 last commits, as it doesn't help anything to have a commit with a problem. |
elsirion
approved these changes
Mar 7, 2024
This was referenced Mar 7, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #4482
Use two levels of
Arcinstead. While at it, rename and document thingsbetter.