fix: wait_for_all_recoveries #4496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maan2003
commented
Mar 7, 2024
fedimint-client/src/lib.rs
Outdated
| @@ -1491,7 +1491,7 @@ impl Client { | |||
| .wait_for(|in_progress| { | |||
| !in_progress | |||
There was a problem hiding this comment.
this is hard, my head hurts
Suggested change
| !in_progress | |
| in_progress |
maan2003
force-pushed
the
push-vxksqlkuollm
branch
from
41f5384
to
5f4e29f
Compare
dpc
approved these changes
Mar 7, 2024
|
There's only so many combinations, we'll get it right eventually. |
bradleystachurski
approved these changes
Mar 8, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
elsirion
approved these changes
Mar 8, 2024
Comment on lines
+1492
to
+1494
| in_progress | ||
| .iter() | ||
| .any(|(_id, progress)| !progress.is_done()) | ||
| .all(|(_id, progress)| progress.is_done()) |
There was a problem hiding this comment.
This only improves readability, there is no functional change here.
To say it with some math:
There was a problem hiding this comment.
There's only so many combinations, we'll get it right eventually.
lol we are repeating combinations now
There was a problem hiding this comment.
Me and Manmeet playing with !, any and all.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.