feat: Rename federation_id() to calculate_federation_id() #4506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The name federation_id() makes it sound like it is just retrieving the id, however it is actually calculating a hash and can take a mild amount of cpu power. Renaming this to calculate_federation_id() implies that there is some work being done and the user should instantiate it as a variable to not duplicate that work. Found a place where this was happening in the codebase already. We did this in serveral places in Mutiny too.
dpc
approved these changes
Mar 8, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name federation_id() makes it sound like it is just retrieving the id, however it is actually calculating a hash and can take a mild amount of cpu power. Renaming this to calculate_federation_id() implies that there is some work being done and the user should instantiate it as a variable to not duplicate that work.
Found a place where this was happening in the codebase already. We did this in several places in Mutiny too.