chore: add method to get recover progress #4509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpc
reviewed
Mar 8, 2024
fedimint-client/src/lib.rs
Outdated
| @@ -1506,6 +1507,11 @@ impl Client { | |||
| Ok(()) | |||
| } | |||
|
|
|||
| pub fn recovery_progress(&self) -> impl Stream<Item = (ModuleInstanceId, RecoveryProgress)> { | |||
There was a problem hiding this comment.
Docstring, and maybe rename to get_recovery_progress_stream?
Nouns <<< Verbs :D
maan2003
force-pushed
the
push-wsrxtrpsmzmk
branch
from
2d6cc3d
to
44ca293
Compare
dpc
previously approved these changes
Mar 8, 2024
maan2003
force-pushed
the
push-wsrxtrpsmzmk
branch
from
44ca293
to
f1c481f
Compare
dpc
previously approved these changes
Mar 8, 2024
maan2003
force-pushed
the
push-wsrxtrpsmzmk
branch
from
f1c481f
to
9005f66
Compare
dpc
approved these changes
Mar 8, 2024
douglaz
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.