chore: make fedimnt-cli module <module> be positional
#4522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
We'll need to conditionally handle for backwards compatibility.
38665 │ 2024-03-10T20:02:24.4435443Z 00:00:33 error: unexpected argument '--module' found
38666 │ 2024-03-10T20:02:24.4435510Z 00:00:33
38667 │ 2024-03-10T20:02:24.4435674Z 00:00:33 tip: to pass '--module' as a value, use '-- --module'
I know that I'm usually advocating for long arguments but: ``` fedimint-cli module --module meat get-consensus ``` is just silly. ``` fedimint-cli module meta get-consensu ``` along with some other improvements i'm working on will make module-specific first class citizens of fedimint-cli.
dpc
force-pushed
the
24-03-10-possitional-arg
branch
from
045d78f
to
6938de4
Compare
bradleystachurski
approved these changes
Mar 11, 2024
m1sterc001guy
approved these changes
Mar 11, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know that I'm usually advocating for long/named arguments but:
is just silly. Instead if we:
along with some other improvements I'm working on will make module-specific CLI a first class citizens of fedimint-cli.