Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump rocksdb from 0.21.0 to 0.22.0 #4532

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

dpc
Copy link
Contributor

@dpc dpc commented Mar 11, 2024

Fix #4528

dependabot bot and others added 2 commits March 11, 2024 17:05
Bumps [rocksdb](https://github.com/rust-rocksdb/rust-rocksdb) from 0.21.0 to 0.22.0.
- [Release notes](https://github.com/rust-rocksdb/rust-rocksdb/releases)
- [Changelog](https://github.com/rust-rocksdb/rust-rocksdb/blob/master/CHANGELOG.md)
- [Commits](rust-rocksdb/rust-rocksdb@v0.21.0...v0.22.0)

---
updated-dependencies:
- dependency-name: rocksdb
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How was rocksdb being linked in 0.21.0? Can you help me understand why we didn't need this file previously?

Copy link
Contributor Author

@dpc dpc Mar 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version provided by nixpkgs was matching, https://search.nixos.org/packages?channel=23.11&from=0&size=50&sort=relevance&type=packages&query=rocksdb

Now I had to override it, by adding an override in a new nix overlay file.

Copy link
Member

@Kodylow Kodylow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@dpc dpc added this pull request to the merge queue Mar 11, 2024
Merged via the queue into fedimint:master with commit 57150ad Mar 12, 2024
20 checks passed
@dpc dpc deleted the 24-03-11-pr4528-update-rocksdb branch March 12, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants