chore: add defaults to just test-compatibility
#4546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradleystachurski
approved these changes
Mar 13, 2024
m1sterc001guy
approved these changes
Mar 13, 2024
elsirion
reviewed
Mar 16, 2024
| @@ -22,10 +22,10 @@ test-ci-all: | |||
| test-count: | |||
| ./scripts/tests/test-cov.sh | |||
|
|
|||
| test-compatibility *VERSIONS: | |||
| test-compatibility *VERSIONS="v0.2.1": | |||
There was a problem hiding this comment.
Is the idea here that this is our MSFMV for now?
There was a problem hiding this comment.
I think so, but pinging @bradleystachurski .
There was a problem hiding this comment.
The motivation for adding the default was to make it less confusing for folks when calling the just command. There was confusion reported in Discord.
Does MSFMV == Minimum Supported Fedimint Version?
There was a problem hiding this comment.
Does MSFMV == Minimum Supported Fedimint Version?
Certainly. :)
And I think, we should probably default to the oldest supported one no matter if it was the initial intention or not. :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.