chore: update jsonrpsee to 0.22.1 #4549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmoon
approved these changes
Mar 13, 2024
maan2003
reviewed
Mar 13, 2024
Comment on lines
-275
to
+272
| jsonrpsee::core::Error::RequestTimeout | ||
| // TODO: find a better error for this, the error we used before: | ||
| // jsonrpsee::core::Error::RequestTimeout | ||
| // was moved to be client-side only | ||
| ErrorObject::owned(-32000, "Request timeout", None::<()>) |
There was a problem hiding this comment.
so this is the -32000 we were hitting before
There was a problem hiding this comment.
I actually don't know what's the right code for request timeout, but jsonrpc error codes are not http codes and are like this.
There was a problem hiding this comment.
yea we should define our own error codes, -32000 is "unknown error code"
maan2003
approved these changes
Mar 13, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need it for something.