refactor(metrics): combined and polish existing ln module metrics #4564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `direction` label to combined contract funding metrics. Drop the counters, histograms already track `<metric>_count` anyway. Shorten the names. Add human-readable descriptions.
dpc
force-pushed
the
24-03-14-prom-app-label-2
branch
from
df58506
to
0461485
Compare
dpc
changed the title
douglaz
approved these changes
Mar 15, 2024
justinmoon
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
directionlabel to combine contract funding metrics.Drop the counters, histograms already track
<metric>_countanyway.
Shorten the names.
Add human-readable descriptions.