fix(db): version field migration never completing #4585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've noticed the `fedimint-cli` keeps printing over and over: ``` 2024-03-16T21:45:20.473825Z INFO db: Migrating DatabaseVersionKeyV0 of ln to DatabaseVersionKey. Version: 1 2024-03-16T21:45:20.473877Z INFO db: Migrating DatabaseVersionKeyV0 of mint to DatabaseVersionKey. Version: 0 2024-03-16T21:45:20.473899Z INFO db: Migrating DatabaseVersionKeyV0 of wallet to DatabaseVersionKey. Version: 0 2024-03-16T21:45:20.473917Z INFO db: Migrating DatabaseVersionKeyV0 of meta to DatabaseVersionKey. Version: 0 2 ``` and it seems it actually never completes it, because there is nothing else to migrate and transaction is terminated early, without completing this one migration.
The way the existing code worked, is that it first opened the database in the temporary directory and then immediately deleted this directory (by droping the `TempDir`) that seems to work OK only as long as the temporary `Database` doesn't do any writes to the dir (commits).
dpc
force-pushed
the
24-03-16-db-version-migratin-fix
branch
from
c0dfa18
to
57fab1e
Compare
m1sterc001guy
approved these changes
Mar 18, 2024
elsirion
approved these changes
Mar 19, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed the
fedimint-clikeeps printing over and over:and it seems it actually never completes it, because there is nothing else to migrate and transaction is terminated early, without completing this one migration. In other words - it does some modifications, than never calls the
commit.