chore(latency-tests): reissue more notes #4587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reissuing is so fast, that it's hard to bench any potential improvements. Issue more notes, to make it work harder. In my tests, when using `ci` build profile: Before: LATENCY REISSUE: min: 0.6s, avg: 0.7s, median: 0.6s, p90: 0.7s, max: 0.7s, sum: 19.5s Now: LATENCY REISSUE: min: 1.3s, avg: 1.4s, median: 1.4s, p90: 1.5s, max: 1.5s, sum: 42.4s
maan2003
approved these changes
Mar 18, 2024
elsirion
approved these changes
Mar 18, 2024
| @@ -132,8 +133,13 @@ pub async fn latency_tests(dev_fed: DevFed, r#type: LatencyTest) -> Result<()> { | |||
| // for enough time to catch up a session end | |||
| let iterations = 30; | |||
| let mut reissues = Vec::with_capacity(iterations); | |||
| let amount_per_iteration_msats = | |||
| // use a highest 2^-1 amount that fits, to try to use as many notes as possible | |||
| @@ -132,8 +133,13 @@ pub async fn latency_tests(dev_fed: DevFed, r#type: LatencyTest) -> Result<()> { | |||
| // for enough time to catch up a session end | |||
| let iterations = 30; | |||
| let mut reissues = Vec::with_capacity(iterations); | |||
| let amount_per_iteration_msats = | |||
| // use a highest 2^-1 amount that fits, to try to use as many notes as possible | |||
| ((initial_balance_sats * 1000 / iterations as u64).next_power_of_two() >> 1) - 1; | |||
There was a problem hiding this comment.
TIL about next_power_of_two 🤯
Note that this might blow up if we ever switch away from base-2 denominations as the default. The only commitment we made and assume everywhere is that denominations are b^x.
There was a problem hiding this comment.
Actually, it should fail gracefully, just not issuing as many notes anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reissuing is so fast now, that it's hard to bench any potential improvements. Issue more notes, to make it work harder.
In my tests, when using
cibuild profile:Before:
LATENCY REISSUE: min: 0.6s, avg: 0.7s, median: 0.6s, p90: 0.7s, max: 0.7s, sum: 19.5s
Now:
LATENCY REISSUE: min: 1.3s, avg: 1.4s, median: 1.4s, p90: 1.5s, max: 1.5s, sum: 42.4s