chore: remove async from TaskGroup::spawn #4601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maan2003
force-pushed
the
ma/jj-wwkzwnovqwmn
branch
2 times, most recently
from
b9db404
to
24589fb
Compare
maan2003
force-pushed
the
ma/jj-wwkzwnovqwmn
branch
from
24589fb
to
a317ad6
Compare
fixes fedimint#4493 command used for replace: rust-analyzer ssr '$tg.spawn($n, $f).await ==>> $tg.spawn($n, $f)'
maan2003
force-pushed
the
ma/jj-wwkzwnovqwmn
branch
from
a317ad6
to
90e2d06
Compare
elsirion
approved these changes
Mar 18, 2024
|
Great cleanup! |
justinmoon
approved these changes
Mar 18, 2024
bradleystachurski
approved these changes
Mar 18, 2024
| @@ -287,7 +296,11 @@ impl TaskGroup { | |||
| info!(target: LOG_TASK, "Subgroup finished"); | |||
| } | |||
|
|
|||
| while let Some((name, join)) = self.inner.join.lock().await.pop_front() { | |||
| // drop lock earl | |||
dpc
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4493
command used for replace: