Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support description hashes for invoices #4615

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

benthecarman
Copy link
Contributor

This is needed along with #3820 for the lightning address server. Without being able to set the description hash some clients will reject the invoice as invalid and will make all resulting zaps invalid as well.

@benthecarman benthecarman requested review from a team as code owners March 19, 2024 02:40
Copy link
Contributor

@m1sterc001guy m1sterc001guy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elsirion elsirion added this pull request to the merge queue Mar 19, 2024
Merged via the queue into fedimint:master with commit 25902da Mar 19, 2024
20 checks passed
@benthecarman benthecarman deleted the desc-hash branch March 19, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants