fix: use update-gateway-cache for v0.3.0 #5171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradleystachurski
force-pushed
the
fix-back-compat
branch
from
7546c8c
to
09bf36d
Compare
bradleystachurski
force-pushed
the
fix-back-compat
branch
from
09bf36d
to
e4ad236
Compare
bradleystachurski
changed the title
dpc
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5156
Fixes #4999
We removed
update-gateway-cachefromfedimint-cliin #4919.v0.3.0includesupdate-gateway-cache(see: https://github.com/fedimint/fedimint/blob/v0.3.0/fedimint-cli/src/client.rs#L126) and doesn't update the cache usinglist-gateways, so we need to handle this case explicitly in back-compat and upgrade tests.Reviewers can verify locally using
and