fix(recoverytest): wait for next session before scanning session outcomes for pegins

[elsirion]

No description provided.

[bradleystachurski]

Thanks for tackling! Looks good as-is, but feel free to address the feedback before merging if you think it simplifies the test.

I'm having trouble reproducing the bug locally, so I'd assume the self-hosted runner with higher loads is needed to repro.

[bradleystachurski]

I think this test was previously using a different (incorrect?) approach to awaiting the session outcome by looping until

        if outputs.len() >= fed_utxos_sats.len() {
            break outputs.clone();
        }

I haven'f fully considered how, but this might be a bug since the epochs method includes descriptors from spent outputs in addition to UTXOs so we might break too early in this loop.

Now that we're explicitly waiting for the session outcome I think we can get rid of the loop and just call the recoverytool with epochs once.

[elsirion]

I removed the loop, good catch!

[bradleystachurski]

For tracking MQ failure #5186

[bradleystachurski]

Oh shoot, the recoverytool failure showed up in the MQ

00:00:39 assertion failed: epochs_descriptors.contains(*utxo_descriptor)

https://github.com/fedimint/fedimint/actions/runs/8911963925/job/24474385524#step:5:925

[dpc]

 00:00:36 2024-05-01T16:28:29.370540Z  INFO devimint::tests: Awaiting session outcome 2
00:00:36 2024-05-01T16:28:29.370598Z DEBUG fm::devimint: > fedimint-cli --data-dir=/tmp/nix-shell.jQkHEI/recoverytool_tests-BPu6/devimint-4154617-577/clients/recoverytool-test-client-0 dev api await_session_outcome 2
00:00:39 2024-05-01T16:28:32.566268Z  INFO devimint::tests: session found in 3.195712726s
00:00:39 2024-05-01T16:28:32.566290Z  INFO devimint::tests: Recovering using epochs method
00:00:39 2024-05-01T16:28:32.566335Z DEBUG fm::devimint: > recoverytool --readonly --cfg /tmp/nix-shell.jQkHEI/recoverytool_tests-BPu6/devimint-4154617-577/fedimintd-0 epochs --db /tmp/nix-shell.jQkHEI/recoverytool_tests-BPu6/devimint-4154617-577/fedimintd-0/database
00:00:39 thread 'main' panicked at /run/github-runner/runner-03-cc/fedimint/fedimint/devimint/src/tests.rs:2144:9:
00:00:39 assertion failed: epochs_descriptors.contains(*utxo_descriptor)
00:00:39 note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

[elsirion]

Uff, now that's weird …

[bradleystachurski]

I'm still having trouble reproducing locally. Let's see if we can figure out more when it flakes again in CI #5192

edit: having trouble reproducing with the self-hosted runner now 😄

[dpc]

Maybe let's land and follow up if/when we spot it again?

[elsirion]

I'm ok with that, but not very satisfying :/

[dpc]

 fedimint-test-all-wasm32-unknown-unknown-ci> 00:01:05 Error: Polling waiting-server-status: VerifyingConfigs failed after 109 retries (timeout: 60s)

That's new.

[justinmoon]

dev call: we thought this was a fix for #5182, but apparently not ...