Refactor server #5264
Merged
Refactor server #5264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joschisan
force-pushed
the
refactor_server
branch
18 times, most recently
from
714f596
to
2fcdcf0
Compare
joschisan
force-pushed
the
refactor_server
branch
5 times, most recently
from
14b62a1
to
a6b4e62
Compare
dpc
previously approved these changes
May 12, 2024
dpc
added
the
needs further review
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
elsirion
previously approved these changes
May 13, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
joschisan
force-pushed
the
refactor_server
branch
11 times, most recently
from
5ead912
to
dcf0183
Compare
joschisan
force-pushed
the
refactor_server
branch
from
dcf0183
to
7c3c8f5
Compare
elsirion
approved these changes
May 14, 2024
Comment on lines
+56
to
71
| pub struct ConsensusEngine { | ||
| pub modules: ServerModuleRegistry, | ||
| pub db: Database, | ||
| pub keychain: Keychain, | ||
| pub federation_api: DynGlobalApi, | ||
| pub cfg: ServerConfig, | ||
| pub submission_receiver: Receiver<ConsensusItem>, | ||
| pub shutdown_receiver: watch::Receiver<Option<u64>>, | ||
| pub last_ci_by_peer: Arc<RwLock<BTreeMap<PeerId, u64>>>, | ||
| /// Just a string version of `cfg.local.identity` for performance | ||
| self_id_str: String, | ||
| pub self_id_str: String, | ||
| /// Just a string version of peer ids for performance | ||
| peer_id_str: Vec<String>, | ||
| connection_status_channels: Arc<RwLock<BTreeMap<PeerId, PeerConnectionStatus>>>, | ||
| task_group: TaskGroup, | ||
| pub peer_id_str: Vec<String>, | ||
| pub connection_status_channels: Arc<RwLock<BTreeMap<PeerId, PeerConnectionStatus>>>, | ||
| pub task_group: TaskGroup, | ||
| } |
There was a problem hiding this comment.
Making stuff pub is ok for now, but this is an internal-only struct and many of its fields are related leading to invariants that need to be upheld, so making everything pub could be kinda misleading (pub fields can be written to arbitrarily in a good API imo, if not there should be a setter) and we probably want to tune it down a bit.
|
review club: @joschisan what ended up being the solution for the problem you saw in CI? Also, it would help in the review club if there was a description. |
|
review club: dpc relayed that the problem was resolved by removing the diff that caused it. We should followup with an investigation to see what we were getting the Edit: more context in discord |
bradleystachurski
removed
the
needs further review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just moving code around.