fix: snapshot level isolation violations #5279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While looking for mistakes in `.snapshot()` use I've noticed that these two (rarely used) methods did not have some existing fixes that the main versions do.
dpc
force-pushed
the
24-05-13-db-isolation
branch
from
a4d477b
to
59e4a50
Compare
This was referenced May 13, 2024
| @@ -168,7 +168,7 @@ impl IRawDatabase for RocksDbReadOnly { | |||
| impl<'a> IDatabaseTransactionOpsCore for RocksDbTransaction<'a> { | |||
| async fn raw_insert_bytes(&mut self, key: &[u8], value: &[u8]) -> Result<Option<Vec<u8>>> { | |||
| fedimint_core::runtime::block_in_place(|| { | |||
| let val = self.0.get(key).unwrap(); | |||
| let val = self.0.snapshot().get(key).unwrap(); | |||
There was a problem hiding this comment.
For onlookers....this was the bug :)
There was a problem hiding this comment.
Can probably remove unwrap here if we want too
|
Great work! 🎉 Wow, that's some unintuitive API on the rocksdb side! So if you use the snapshot struct for reading then what it actually does is read from the DB transaction, but setting the snapshot in the read options for each read (I was worried that it would only read from the snapshot at first). |
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5271
Fix #5195