gateway ui fixes #218
Merged
gateway ui fixes #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
okjodom
commented
Oct 6, 2023
okjodom
commented
- removes quotations around deposit address
- shows gateway balance as sats (instead of msats)
- shows the correct balance available for withdrawal
- fixes number input in withdraw card
- enables 'withdraw all button' though this should not be used?
- shows the right amount withdrawable balance - fixes bug in amount input field - adds functionality to 'withdraw all' button
wbobeirne
approved these changes
Oct 6, 2023
Comment on lines
+97
to
+99
| onChange={(value) => { | ||
| value && setAmount(parseInt(value)); | ||
| }} |
There was a problem hiding this comment.
I would avoid attempting to parse an int in state, since inputs work only on strings. We should probably keep this as a string and only parse when we're performing numeric operations. This can cause issues with sufficiently large numbers
There was a problem hiding this comment.
This is no worse than it currently is though, so it's fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.