-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
guardian-ui: fix config verification #268
Conversation
94f2bec
to
ed63847
Compare
ed63847
to
7bef118
Compare
7bef118
to
77e70b4
Compare
0dcdc22
to
8cc5d99
Compare
@okjodom I hit continue with the leader before verifying all configs on all followers, and got stuck on this screen: Is this a regression from fedimint/fedimint#3547? I was unable to get this to happen in |
do you mean current repo |
Apologies, I meant |
Figured I didn't properly update flake lock - now it's taking forever to recompile devimint after bump🤦🏿♂️ |
8cc5d99
to
2473715
Compare
help me close this bug, @wbobeirne , @Kodylow |
- this hash includes the upstream changes needed for the config verification fix. See fedimint/fedimint#3547
2473715
to
5302018
Compare
Ran the tests with this yesterday closing leader's tab and refreshing everything, looks good to me. |
thanks for the review. landing fix |
At the config verification step after all the guardians have verified other configs, if the leader continued their own setup to completion before the follower guardians, there is a chance the followers would not be able to resume and complete their setup since we relied on their servers being able to continuously poll the leader's server for consensus configuration.
This PR fixes the bug, allowing all guardians to complete federation set-up in any order, provided they have successfully coordinated through config verification.
Steps to validate
Fixes #255