Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant copy #309

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Conversation

Kodylow
Copy link
Member

@Kodylow Kodylow commented Nov 16, 2023

Leader and Follower already answer "Are you creating a Federation or joining one?", also "joining" is unclear given distinction between guardian and client.

okjodom
okjodom previously approved these changes Nov 16, 2023
@Kodylow Kodylow dismissed okjodom’s stale review November 16, 2023 19:02

The merge-base changed after approval.

okjodom
okjodom previously approved these changes Nov 16, 2023
@Kodylow Kodylow dismissed okjodom’s stale review November 16, 2023 19:11

The merge-base changed after approval.

@Kodylow Kodylow force-pushed the remove-redundant-copy branch 3 times, most recently from caddfc4 to e863abd Compare November 16, 2023 19:49
fix: copy on first page

fix: korean
@okjodom okjodom merged commit 30fb983 into fedimint:master Nov 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants