Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: trashcan icon for custom meta fields #345

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

Kodylow
Copy link
Member

@Kodylow Kodylow commented Dec 20, 2023

image

fixes #344

Having the box for the Derived ones makes the spacing look nicer, tried both ways and when you don't leave the spacing then the center gap looks weird.

@Kodylow Kodylow requested a review from a team as a code owner December 20, 2023 22:18
@Kodylow Kodylow requested review from wbobeirne and removed request for a team December 20, 2023 22:19
Copy link
Collaborator

@wbobeirne wbobeirne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, would be nice to look into the other horizontal cut-off issue at some point though: #344 (comment)

@okjodom okjodom merged commit e475ae7 into fedimint:master Dec 20, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Guardian cannot remove meta fields during setup
3 participants