feat: Leave Federation #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okjodom
reviewed
Jan 23, 2024
okjodom
reviewed
Jan 23, 2024
| children, | ||
| }: FedNameCardProps) { | ||
| const [isOpen, setIsOpen] = React.useState(false); |
There was a problem hiding this comment.
nit: we should use descriptive state names like confirmLeaveFed
okjodom
reviewed
Jan 23, 2024
| children, | ||
| }: FedNameCardProps) { | ||
| const [isOpen, setIsOpen] = React.useState(false); | ||
| const [errorMessage, setErrorMessage] = React.useState<string | null>(null); |
There was a problem hiding this comment.
nit: import-style: we should just import react fns at the top
okjodom
reviewed
Jan 23, 2024
| } else { | ||
| throw new Error('Federation ID is null'); | ||
| } | ||
| } catch (error: any) { |
There was a problem hiding this comment.
lint: catch (error: unknown)
There was a problem hiding this comment.
or just leave out the type
okjodom
reviewed
Jan 23, 2024
There was a problem hiding this comment.
aside from nits and lints, this looks good to me.
great because gateway admins can now quickly leave fed
Need design input on how to view multiple federations too, think we're at the point we can start implementing that
let's track separately: #356
|
Updated UI: 
|
okjodom
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs design input and I think we should use toasts for errors we've got that whole section in the top right that's blank rn.
Need design input on how to view multiple federations too, think we're at the point we can start implementing that