fix: set numPeers correctly #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EthnTuttle
reviewed
Mar 2, 2024
EthnTuttle
reviewed
Mar 2, 2024
okjodom
reviewed
Mar 18, 2024
| @@ -31,7 +31,6 @@ export const ConnectGuardians: React.FC<Props> = ({ next }) => { | |||
| const { | |||
| state: { role, peers, numPeers, configGenParams, ourCurrentId }, | |||
| } = useSetupContext(); | |||
|
|
|||
There was a problem hiding this comment.
nit: unnecessary change in file
| @@ -23,19 +23,7 @@ const LOCAL_STORAGE_SETUP_KEY = 'setup-guardian-ui-state'; | |||
| * Creates the initial state using loaded state from local storage. | |||
| */ | |||
| function makeInitialState(loadFromStorage = true): SetupState { | |||
There was a problem hiding this comment.
Hey @Kodylow , this is the actual fix to the bug! Nice fix. Could we just scope the PR to changes in this file and we land it?
Kodylow
force-pushed
the
fix-context-refresh
branch
from
bb68f2b
to
763424d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #385
We weren't properly loading the state from localStorage, and we were setting numPeers from connected Peers not from stateNumPeers. This lets the setup leader refresh and maintain state and connections to peers, and doesn't kick to DKG immediately on refresh.