feat: authenticate as a guardian #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kodylow
force-pushed
the
guardian-connection
branch
from
c069930
to
2f95f91
Compare
|
To avoid people accidentally revealing this I moved it into a new "Danger Zone" section at the bottom and added a warning before revealing the QR code: 
|
Kodylow
force-pushed
the
guardian-connection
branch
from
1a8fb29
to
9f56c9f
Compare
|
Should there be a warning to make sure one is in an environment where nobody can see/film their screen? |
|
@elsirion that's what I was doing with this, it shows that then you click reveal, do you want me to add more? 
|
Kodylow
force-pushed
the
guardian-connection
branch
from
97e7657
to
817e6db
Compare
elsirion
reviewed
Mar 30, 2024
| password: password || '', | ||
| }).toString(); | ||
|
|
||
| return `guardian:authenticate?${params}`; |
There was a problem hiding this comment.
We should standardize the protocol prefix for all things Fedimint
Kodylow
force-pushed
the
guardian-connection
branch
from
817e6db
to
310a098
Compare
otech47
reviewed
Apr 12, 2024
otech47
reviewed
Apr 12, 2024
otech47
reviewed
Apr 12, 2024
otech47
reviewed
Apr 12, 2024
otech47
previously approved these changes
Apr 12, 2024
Kodylow
force-pushed
the
guardian-connection
branch
from
bc4cda0
to
e8ceeb4
Compare
Kodylow
force-pushed
the
guardian-connection
branch
from
e8ceeb4
to
a5cae7b
Compare
otech47
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a button to toggle on
guardian:in front of the invite code QR code so a client app can start an auth flow.