Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: show federation name in gateway ui #399

Merged
merged 1 commit into from
Mar 27, 2024
Merged

feat: show federation name in gateway ui #399

merged 1 commit into from
Mar 27, 2024

Conversation

okjodom
Copy link
Collaborator

@okjodom okjodom commented Mar 25, 2024 •
edited

fixes #368
image

@okjodom okjodom requested a review from a team as a code owner March 25, 2024 18:43
@okjodom okjodom requested a review from Kodylow March 25, 2024 19:03
Kodylow
Kodylow approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@Kodylow Kodylow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

think federation name is optional in meta otherwise good to go

@okjodom
Copy link
Collaborator Author

okjodom commented Mar 27, 2024

think federation name is optional in meta otherwise good to go

ack. I made federation name in BalanceCardProps nullable. The experience falls back to the federation id as name

@Kodylow Kodylow merged commit f5a7283 into fedimint:master Mar 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kodylow Kodylow Kodylow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add back federation name to gateway api
2 participants
@okjodom @Kodylow