fix: required config gen local and consensus + fix password runtime error #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elsirion
approved these changes
Mar 30, 2024
alexlwn123
reviewed
Apr 2, 2024
| @@ -285,6 +285,7 @@ export const SetupContextProvider: React.FC<SetupContextProviderProps> = ({ | |||
| // Followers set their own connection name, and hosts server URL to connect to. | |||
| await api.setConfigGenConnections(myName, configs.hostServerUrl); | |||
|
|
|||
| console.log('configs', configs); | |||
There was a problem hiding this comment.
Nit: cleanup console logs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #397
Consensus and Local are now required for submitting module params in setup so we don't filter them out anymore for the follower, plus me and eric ran into a runtime issue where the password was nulled on refresh that this fixes by doing a !!password check