Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random Guardian Names #407

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Conversation

Kodylow
Copy link
Member

@Kodylow Kodylow commented Apr 3, 2024

This just sets a random guardian name for the user instead of letting them pick one.

Until we have something like a nostr login where you can testify to being a guardian the names here are useless and cause a bunch of headaches during setup if users don't want to correlate that they're also guardians.

@Kodylow Kodylow requested a review from a team as a code owner April 3, 2024 20:29
@okjodom
Copy link
Collaborator

okjodom commented Apr 4, 2024

This makes most sense in dev scenarios where one person is pretending as several guardians. In scenarios with several actual guardians, I imagine random names takes away "chance of agency" for the guardians, and probably makes it more painful to delete the pre-filled random name, to write their own names

@Kodylow
Copy link
Member Author

Kodylow commented Apr 4, 2024

I completely removed the ability to put your own name in, it only uses random. Since they're not cryptographically signing anything to prove who they are, the name is only useful for the setup ceremony and for privacy they shouldn't be using their real name for it. The name serves more as an identifier to the other guardians so using something like this is better.

Copy link
Collaborator

@okjodom okjodom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense. Ship it

@Kodylow Kodylow merged commit 745ffb7 into fedimint:master Apr 4, 2024
1 check passed
@Kodylow Kodylow deleted the random-guardian-names branch April 4, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants