fix: additional confirmations clarification

[Kodylow]

Clarifies that these are "additional" confirmations and explains why we need them. Feedback that this has been confusing to users.

Summary by CodeRabbit

• New Features

  • Updated label and text related to block confirmations for clearer guidance on Fedimint security.

• Bug Fixes

  • Adjusted the recommended minimum block confirmations from 6 to 5 and the minimum from 1 to 0 in Bitcoin settings.

• Improvements

  • Expanded the validation range for block confirmations to 0-200 and refined finality delay calculations for enhanced accuracy.

[coderabbitai]

Walkthrough

Walkthrough

The overall changes focus on enhancing the ConnectGuardians and SetConfiguration components regarding block confirmations. These modifications include UI label adjustments, changing values for better flexibility and clarity in form validation, and updating language files to emphasize the criticality of additional block confirmations for Fedimint security.

Changes

File Path	Change Summary
.../connectGuardians/ConnectGuardians.tsx	Label for 'Block confirmations' changed to 'Additional Block Confirmations'.
.../setConfiguration/BitcoinSettingsForm.tsx	Changed recommendedMin from 6 to 5, and min value from 1 to 0.
.../setConfiguration/SetConfiguration.tsx	Validation range for blockConfirmations modified from 1-200 to 0-200; updated finalityDelay calculation.
.../languages/en.json	Updated text to highlight the importance of additional block confirmations and adjusted warning about block confirmations.

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between bb3b83f and 84cac5a.

Files selected for processing (4)

• apps/guardian-ui/src/components/setup/screens/connectGuardians/ConnectGuardians.tsx (1 hunks)
• apps/guardian-ui/src/components/setup/screens/setConfiguration/BitcoinSettingsForm.tsx (1 hunks)
• apps/guardian-ui/src/components/setup/screens/setConfiguration/SetConfiguration.tsx (3 hunks)
• apps/guardian-ui/src/languages/en.json (1 hunks)

Files skipped from review due to trivial changes (1)

• apps/guardian-ui/src/components/setup/screens/setConfiguration/BitcoinSettingsForm.tsx

Additional comments not posted (6)

apps/guardian-ui/src/components/setup/screens/connectGuardians/ConnectGuardians.tsx (1)

91-91: Label change approved

The label change to 'Additional Block Confirmations' correctly reflects the intended clarification.

apps/guardian-ui/src/components/setup/screens/setConfiguration/SetConfiguration.tsx (2)

127-127: Validation range update approved

The validation range for blockConfirmations has been correctly updated from 1-200 to 0-200.

Also applies to: 137-137

---

178-178: Calculation update approved

The calculation of finalityDelay has been correctly updated to remove the subtraction of 1 from the blockConfirmations value.

apps/guardian-ui/src/languages/en.json (3)

175-175: Label change approved

The label change to 'Additional Block Confirmations' correctly reflects the intended clarification.

---

176-176: Help message update approved

The help message now provides clearer guidance on the concept of additional block confirmations.

---

177-177: Warning message update approved

The warning message now emphasizes the risks associated with fewer block confirmations more clearly.

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.