Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove missing 'follow_redirects' parameter #71

Conversation

MikePlayle
Copy link

Simplest possible fix for the following failure which I saw:

2024-05-11T13:35:37Z [ERROR] feditest: FAILED test (other reason): webfinger.server.4__3_only_returns_jrd_in_response_to_https_requests::only_returns_jrd_in_response_to_https: WebClient.http_get() got an unexpected keyword argument 'follow_redirects' Traceback (most recent call last):

  File "/home/mike/devel/fediverse/feditest/feditest/venv/lib/python3.11/site-packages/feditest/__init__.py", line 91, in run
    self.test_function(**args)

  File "/home/mike/devel/fediverse/feditest/feditest-tests-fediverse/tests/webfinger/server/4__3_only_returns_jrd_in_response_to_https_requests.py", line 27, in only_returns_jrd_in_response_to_https
    http_response : HttpResponse = client.http_get(http_webfinger_uri, follow_redirects=False).response
                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

TypeError: WebClient.http_get() got an unexpected keyword argument 'follow_redirects'

Fixes the 4__3_only_returns_jrd_in_response_to_https_requests test.

The client in src/feditest/nodedrivers/imp/__init__.py already disables
redirects, so the simplest fix is to remove this parameter completely.
@steve-bate
Copy link
Member

I think this is a side-effect from merging dependent PRs out-of-order. Feditest PR #97 adds the follow_redirects argument, which defaults to True.

@jernst
Copy link
Member

jernst commented May 16, 2024

@jernst jernst closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants