Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terminology in run_vfl_fc_two_party_lending_club.py #61

Closed
peiji1981 opened this issue Nov 6, 2020 · 8 comments
Closed

terminology in run_vfl_fc_two_party_lending_club.py #61

peiji1981 opened this issue Nov 6, 2020 · 8 comments
Assignees
Labels
good first issue Good for newcomers question Further information is requested

Comments

@peiji1981
Copy link

hello, i may find a mistake in run_vfl_fc_two_party_lending_club.py . only party_a has label , so party_a may be host not guest ?

@chaoyanghe
Copy link
Member

@yankang18 Hi Yan Kang, please help to check whether this is an error.

@yankang18
Copy link

@peiji1981 In the current vertical federated learning setting, only party A has labels. Other parties only provide features for building the federated model.

The guest typically refers to the party that has an application scenario such as loan lending (it has labels) but it lacks data (e.g., features) to build a good prediction model.
The host typically refers to the data provider that offers rich data (e.g. features) for helping guests to build machine learning models.

@peiji1981
Copy link
Author

@peiji1981 In the current vertical federated learning setting, only party A has labels. Other parties only provide features for building the federated model.

The guest typically refers to the party that has an application scenario such as loan lending (it has labels) but it lacks data (e.g., features) to build a good prediction model.
The host typically refers to the data provider that offers rich data (e.g. features) for helping guests to build machine learning models.

Thx, buddy . But this setting may be confused. Generally, the host has label

@chaoyanghe
Copy link
Member

@peiji1981 In the current vertical federated learning setting, only party A has labels. Other parties only provide features for building the federated model.
The guest typically refers to the party that has an application scenario such as loan lending (it has labels) but it lacks data (e.g., features) to build a good prediction model.
The host typically refers to the data provider that offers rich data (e.g. features) for helping guests to build machine learning models.

Thx, buddy . But this setting may be confused. Generally, the host has label

So the code is correct. It doesn't matter how to call one of the parties.

@yankang18
Copy link

@peiji1981

Different scenarios may use different terminology. To avoid confusion, we may use a more neutral name for the host and guest.

@chaoyanghe
Copy link
Member

@yankang18 how about drawing a diagram to illustrate our current implementation?

@chaoyanghe chaoyanghe changed the title mistake in run_vfl_fc_two_party_lending_club.py terminology in run_vfl_fc_two_party_lending_club.py Nov 9, 2020
@chaoyanghe chaoyanghe added the good first issue Good for newcomers label Nov 9, 2020
@peiji1981
Copy link
Author

@yankang18 how about drawing a diagram to illustrate our current implementation?

hello, Dr.He, can you share a link for download the lendingclub dataset , the previous link did not conclude the data

@chaoyanghe chaoyanghe self-assigned this Aug 17, 2022
@fedml-dimitris fedml-dimitris added the question Further information is requested label Oct 24, 2023
@fedml-dimitris
Copy link
Contributor

Closing this issue, since it is not related to a problem of the FedML library but rather to how to tackle a vertical federated learning setting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants