Fix filters in URL on search page #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mgrabovsky
commented
Jun 8, 2023
•
mgrabovsky
commented
- Fix filters not working (OSCI-5140)
- Upgrade react-router-dom
- Fix code style in filters Redux slice
- Update last bit of code after React Redux 8 & Redux Toolkit migration
mgrabovsky
changed the title
Use camel case for variable names and object spreads to merge two maps.
Reference: OSCI-5140
Use the specialized `useAppDispatch()` and `useAppSelector()` hooks everywhere. Follow-up to #64
mgrabovsky
force-pushed
the
fix-filters-url
branch
from
83963d0
to
4ff9a5b
Compare
|
@mgrabovsky looks good, where was the main issue ? |
Andrei-Stepanov
approved these changes
Jun 8, 2023
|
I think the main issue was the loading of the URL filters that relied on the old mechanism, i.e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.