Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let's have separate webhooks for each package in copr #2640

Closed
FrostyX opened this issue Apr 3, 2023 · 1 comment
Closed

Let's have separate webhooks for each package in copr #2640

FrostyX opened this issue Apr 3, 2023 · 1 comment
Labels
RFE Enhancement, feature requests

Comments

@FrostyX
Copy link
Member

FrostyX commented Apr 3, 2023

Original issue: https://bugzilla.redhat.com/show_bug.cgi?id=1344191
Opened: 2016-06-09 06:08:47
Opened by: Pavel Raiskup


Pavel Raiskup commented at 2016-06-09 06:08:47:

ATM, webhook in Copr triggers build of all packages that are configured to be
built by webhook. Because different package might come from different source
repositories, it is at least wasting of resources to spin the builds for all
packages when only one of them was changed; but it also very likely will
break the repository.


commented at 2016-06-13 05:08:47:

Good point!


Pavel Raiskup commented at 2017-12-15 09:03:40:

(In reply to Pavel Raiskup from comment #0)

Because different package might come from different source repositories, it
is at least wasting of resources

Seems like there's some work-around for this trying to match source repository
where the webhook comes from with the "SCM's git repo" url. This is however
rather non-flexible - giving the CI work-flow artificial limits. Eg:

Per https://docs.pagure.org/copr.copr/webhook_hacking.html#webhook-hacking

The payload dict requested ^^ is just pain, one would like to do just
'curl https://copr.fedorainfracloud.org/webhooks/github/16322/0bdb2d04-30f5-41d5-8e9d-da27c38ef426/' and that's it.

Per https://docs.pagure.org/copr.copr/user_documentation.html

The only source type which make sense together with webhooks is “SCM”.

Meh, this is rather ugly limitation :(. The CI (e.g. some Jenkins jobs)
can create the tarball + spec => and srpm, and provide that srpm on some
public url (so srpm-url method might succeed).

@FrostyX FrostyX added the RFE Enhancement, feature requests label Apr 3, 2023
@praiskup
Copy link
Member

This has likely been resolved by the custom method/custom webhook (which is per-package). Please reopen if you disagree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFE Enhancement, feature requests
Projects
Archived in project
Development

No branches or pull requests

2 participants