Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run docker image on Travis and update it (F32, Flask, Ansible bootstrap) #805

Merged
merged 1 commit into from Oct 12, 2020
Merged

Run docker image on Travis and update it (F32, Flask, Ansible bootstrap) #805

merged 1 commit into from Oct 12, 2020

Conversation

abitrolly
Copy link
Contributor

@abitrolly abitrolly commented Aug 14, 2019 •
edited

This adds a couple of fixes to containerized Anitya. In the final form, it should be possible to do this.

$ podman build -t anitya .
$ podman run -it -p 8080:80 anitya

http://127.0.0.1:8080

This PR replaces Apache with Flask, removes the remains of Apache config, and reuses Ansible playbooks for Vagrant for setting up Docker image.

@abitrolly abitrolly mentioned this pull request Nov 27, 2019
Closed
@codecov-io
Copy link

codecov-io commented Jan 1, 2020 •
edited by codecov bot

Codecov Report

Merging #805 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #805   +/-   ##
=======================================
  Coverage   97.11%   97.11%           
=======================================
  Files          65       65           
  Lines        4131     4131           
  Branches      561      561           
=======================================
  Hits         4012     4012           
  Misses         71       71           
  Partials       48       48

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4fd591...7fab829. Read the comment docs.

@abitrolly abitrolly requested a review from a team as a code owner October 10, 2020 20:42
@Zlopez
Copy link
Contributor

Zlopez commented Oct 12, 2020

Is this now ready for merging?

@abitrolly abitrolly changed the title Run docker image on Travis and update to Fedora 30 Run docker image on Travis and update it (F32, Flask, Ansible bootstrap) Oct 12, 2020
@abitrolly
Copy link
Contributor Author

@Zlopez should be ready to be merged once tests pass. I still haven't figured out all the bits to run Anitya. After this PR is merged, only Ansible playbooks need to be tweaked for that to happen.

Zlopez
Zlopez requested changes Oct 12, 2020
View reviewed changes
Copy link
Contributor

@Zlopez Zlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and even the tests are going through. Could you just squash the commits?

@abitrolly
docker: Hacktober work towards Anitya containerization
7fab829 
 * Update to F32 (on par with Vagrant)
 * Run docker image on Travis
 * Replace SECRET_KEY in Docker image on DB init

Replace `secret_key` if the config already exists,
and create config if there is no such file yet.

 * Anitya source is in /app

https://docs.docker.com/develop/develop-images/dockerfile_best-practices/

 * Rip off Apache and use Flask
 * Reuse Ansible role for installing packages in Dockerfile
 * ansible: Make location of Anitya src configurable
@abitrolly
Copy link
Contributor Author

abitrolly commented Oct 12, 2020 •
edited

Done squashing. Tests don't touch Ansible playbooks. Current playbooks can only be tested by remaking vagrant up locally, but vagrant up didn't work for me and I haven't found the time to report the bugs with libvirt that occurred.

@Zlopez
Copy link
Contributor

Zlopez commented Oct 12, 2020 •
edited

I'm using vagrant up for daily work on Anitya, if you are talking about provisioning playbooks, I can confirm they are working.

@Zlopez
Copy link
Contributor

Zlopez commented Oct 12, 2020

But I didn't tried your changes, let me check.

@Zlopez
Copy link
Contributor

Zlopez commented Oct 12, 2020

I tried vagrant up on your PR and it's working without issue. 👍

@mergify mergify bot merged commit dcdc941 into fedora-infra:master Oct 12, 2020
@abitrolly abitrolly deleted the docker2 branch October 13, 2020 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zlopez Zlopez Zlopez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@abitrolly @codecov-io @Zlopez