Use urljoin for update URLs construction

Signed-off-by: Mattia Verga <mattia.verga@tiscali.it>

bodhi-server/bodhi/server/models.py

@@ -20,9 +20,9 @@
 from datetime import date, datetime, timedelta
 from functools import lru_cache
 from textwrap import wrap
+from urllib.parse import urljoin
 import hashlib
 import json
-import os
 import re
 import time
 import typing
@@ -3421,9 +3421,7 @@ def get_url(self):
         Returns:
             str: A URL.
         """
-        path = ['updates']
-        path.append(self.alias)
-        return os.path.join(*path)
+        return f'updates/{self.alias}'
 
     def abs_url(self, request=None):
         """
@@ -3433,7 +3431,7 @@ def abs_url(self, request=None):
             request (pyramid.request.Request or None): The current web request. Unused.
         """
         base = config['base_address']
-        return os.path.join(base, self.get_url())
+        return urljoin(base, self.get_url())
 
     url = abs_url
 

news/5566.bug

@@ -0,0 +1 @@
+Use urljoin for update URLs construction