Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a fedmsg-client to update test gating status on new Greenwave decisions #1513

Closed
pypingou opened this issue May 12, 2017 · 10 comments
Closed
Assignees
Labels
High priority These issues are higher priority than normal RFE Requests for Enhancement

Comments

@pypingou
Copy link
Member

We need a fedmsg-client to listen to CI messages and update the corresponding bodhi update (if there are any corresponding to this commit).

@bowlofeggs bowlofeggs added High priority These issues are higher priority than normal RFE Requests for Enhancement labels May 12, 2017
@pypingou pypingou self-assigned this May 12, 2017
@bowlofeggs
Copy link
Contributor

This is blocked on us knowing what fedmsgs will come and from where for the various ci statuses. We need "something" to send messages on these events:

  1. The build will not be tested (skipped).
  2. The build is queued for testing.
  3. The build is currently being tested.
  4. The tests passed.
  5. The tests failed.

Do we know what will provide these various messages? Will they all come from Greenwave, or will some come from it and others from elsewhere?

@bowlofeggs
Copy link
Contributor

CC @ralphbean Do you have answers to my above question, and answers for any other problems I may encounter in life?

@pypingou
Copy link
Member Author

pypingou commented Jul 5, 2017

The build will not be tested (skipped).
The build is queued for testing.
The build is currently being tested.

I think these three will come from the CI system, I am not sure if taskotron sends messages when it starts testing an update, would be worth checking.

The other two will be also sent by the CI system but we should ignore them and just act on the messages from greenwave

@bowlofeggs
Copy link
Contributor

@pypingou Cool, that sounds reasonable to me. I have a few follow up questions that we'll want to answer in order to get started on coding:

  1. What will the message topics be for the various messages?
  2. Similarly, what will the message schema be?

It's tricky to get started with coding unless we know those things. Is CI running anywhere yet that we can see real messages? If it were, that would help me get started on this.

Technically, we can go without this if we do #1515, since that one will get us "eventual consistency" so I guess it is an option to delay fixing this issue until we have CI in place so we have real data to code against. Maybe that wouldn't be a bad way to go?

@bowlofeggs
Copy link
Contributor

@ralphbean Will Greenwave be emitting fedmsgs as tests pass, or does Greenwave only react to web requests? I.e., is it "passive" or "active", if that makes sense?

@pypingou
Copy link
Member Author

pypingou commented Jul 7, 2017

What will the message topics be for the various messages?
Similarly, what will the message schema be?

The end part of the topic as well as the structure is defined at: https://github.com/CentOS-PaaS-SIG/ci-pipeline/#message-bus if something change we should report it to them but I think that's what I based my work on and it worked :)

@bowlofeggs
Copy link
Contributor

@pypingou great! OK I have one more question (sorry for so many) - where can we look up whether builds are skipped if we miss the fedmsgs?

@pypingou
Copy link
Member Author

where can we look up whether builds are skipped if we miss the fedmsgs?

Currently it's in ccsdb, but ultimately this should be in resultsdb as well

@bowlofeggs bowlofeggs changed the title Create a fedmsg-client to update CI status on new CI results Create a fedmsg-client to update test gating status on new Greenwave decisions Sep 25, 2017
@bowlofeggs
Copy link
Contributor

This is blocked by https://pagure.io/greenwave/issue/87.

@mikebonnet
Copy link

For reference, https://pagure.io/greenwave/issue/87 was completed at the end of October.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High priority These issues are higher priority than normal RFE Requests for Enhancement
Projects
None yet
Development

No branches or pull requests

3 participants