Obsolete updates when a newer one is pushed to stable #4446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattiaverga
force-pushed
the
obsolete_freeze
branch
from
c980595
to
9da2311
Compare
|
This is rebased on #4447 |
Signed-off-by: Mattia Verga <mattia.verga@tiscali.it>
mattiaverga
force-pushed
the
obsolete_freeze
branch
from
bcc1e26
to
be1d7b9
Compare
abompard
approved these changes
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently ignore obsoleting updates which are being pushed to stable. The rationale is that we can create an update with a newer build and push it to testing while allowing the older one to be pushed stable meanwhile.
Unfortunately, this doesn't work well when a release is frozen, as we may end up with several builds all stuck in testing being pushed to stable. When the freeze is lifted, not only the newer build is pushed to stable, but Bodhi will try to push the older too.
This PR is an attempt to fix that by allowing Bodhi to obsolete updates being pushed to stable, but only when the newer update is pushed to stable too. To achieve that I've added a call to
obsolete_older_updatesat the end ofset_requestand modified the query used to identify obsoletable candidates.Signed-off-by: Mattia Verga mattia.verga@tiscali.it