Add a database schema image to the docs #1150
Conversation
|
It looks like this |
| - name: Install sqlalchemy_schemadisplay | ||
| command: pip install sqlalchemy_schemadisplay | ||
| args: | ||
| creates: /usr/lib/python2.7/site-packages/sqlalchemy_schemadisplay.py |
There was a problem hiding this comment.
I assume this isn't packaged for Fedora? If so, we will need to package it, because the bodhi package in Fedora builds the docs. If this isn't present, will the docs build fail?
There was a problem hiding this comment.
@jeremycline Can you move this to be installed by RPM in the list above, with the assumption that it will be called python2-sqlalchemy_schemadisplay?
|
This looks great! I think we should get that sqlalchemy thing packaged for Fedora so the docs will build. I don't mind taking that on, unless you want to do it. Until that is present in Fedora/EPEL 7, I think we need to hold this PR so we don't end up having it be a release blocker. |
|
I talked to @jeremycline in person and I agreed to package |
| - name: Install sqlalchemy_schemadisplay | ||
| command: pip install sqlalchemy_schemadisplay | ||
| args: | ||
| creates: /usr/lib/python2.7/site-packages/sqlalchemy_schemadisplay.py |
There was a problem hiding this comment.
@jeremycline Can you move this to be installed by RPM in the list above, with the assumption that it will be called python2-sqlalchemy_schemadisplay?
|
The package review is now approved, so we just need to get it built and released for the Vagrant environment to merge this. If you want, you can use the koji |
jeremycline
force-pushed
the
schema-image
branch
from
b9ee1ea
to
fa94f61
Compare
This generates a schema diagram from the SQLAlchemy models. Signed-off-by: Jeremy Cline <jeremy@jcline.org>
jeremycline
force-pushed
the
schema-image
branch
from
fa94f61
to
a4aefe1
Compare
|
I have built it for Rawhide through EPEL 7 and updated the PR to install the RPM package from Koji with a note about changing it when the F24 update is stable. |
This generates a schema diagram from the SQLAlchemy models.
Signed-off-by: Jeremy Cline jeremy@jcline.org