make the autokarma checkbox on edit update persistent #1693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bowlofeggs
approved these changes
Jul 19, 2017
There was a problem hiding this comment.
Looks good to me, but I have a suggestion wrt the commit message: I suggest adding this to it:
fixes #1482
fixes #1308
Technically, I think the three bugs are all duplicates, but we can just mark them all as fixed. Or another option is just to close the others as duplicates. Either way, feel free to merge!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the autokarma checkbox in the edit update form
was always set to on, regardless of the value set in the DB.
This commit fixes this, so the checkboxis set with the value
in the db for the update.
fixes #1692
fixes #1482
fixes #1308