Move the migrations into the Bodhi package #1777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just moved it to |
jeremycline
force-pushed
the
migration-subpackage
branch
from
04697f5
to
7935d6f
Compare
bowlofeggs
approved these changes
Sep 6, 2017
| @@ -3,6 +3,7 @@ source = bodhi | |||
| omit = | |||
| bodhi/scripts/* | |||
There was a problem hiding this comment.
Not related to this PR, but this path doesn't seem to exist.
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| [alembic] | |||
| # path to migration scripts | |||
| script_location = alembic | |||
| script_location = bodhi:server/migrations | |||
There was a problem hiding this comment.
This could be a backwards-incompatible change for the RPM, since alembic.ini is probably marked as a configuration file. This means that users who upgrade will not get this change and the migrations will fail. Two possible solutions I can think of quickly:
- Don't mark this as a config file. Does it have anything an end user should want to change in it? I'm not sure.
- Provide a symlink from the old location to the new location so things work smoothly, and drop the symlink in Rawhide. We already do this with another symlink on F26.
I'd probably opt for the second one.
| ^^^^^^^^^^^^^^^^^^^^^^^^ | ||
|
|
||
| * The database migrations are now shipped as part of the Python distribution | ||
| (`#1777 <https://github.com/fedora-infra/bodhi/pull/1777>`_). |
There was a problem hiding this comment.
It would be good to mention the alembic.ini change here.
jeremycline
force-pushed
the
migration-subpackage
branch
2 times, most recently
from
38d9308
to
988e055
Compare
Alembic makes it easy to distribute the migrations as part of your Python package. It also makes configuration easy since it uses pkg_resources to find the migrations, rather than having the user configure the path as part of packaging. Signed-off-by: Jeremy Cline <jeremy@jcline.org>
jeremycline
force-pushed
the
migration-subpackage
branch
from
988e055
to
fca55d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alembic makes it easy to distribute the migrations as part of your
Python package. It also makes configuration easy since it uses
pkg_resources to find the migrations, rather than having the user
configure the path as part of packaging.
Signed-off-by: Jeremy Cline jeremy@jcline.org