Add support for Cornice 2, dropping support for Cornice 1. #1958
Conversation
bowlofeggs
added
API
bowlofeggs
force-pushed
the
1922
branch
3 times, most recently
from
a64dd75
to
88403f3
Compare
bowlofeggs
force-pushed
the
1922
branch
2 times, most recently
from
ed328f8
to
3268836
Compare
| @@ -14,6 +14,7 @@ | |||
|
|
|||
| from datetime import datetime, timedelta | |||
|
|
|||
| from cornice.validators import _colander | |||
There was a problem hiding this comment.
@jeremycline Perhaps it will assuage your fears to know that I've only used this private API temporarily until there is an upstream release that has the _generate_colander_validator() that I wrote below.
I've pitched that code upstream and I have the PR approved, but it needs some tests:
So it's only a private API because I wanted to use the exact same thing that will eventually be in an upstream Cornice release.
There was a problem hiding this comment.
Oh and actually, the public API that will ultimately be upstream will actually be the colander_querystring_validator() that is made by _generate_colander_validator(). So once this is upstream, I will remove the code from this file and just use it directly from cornice.
| - python2-sqlalchemy_schemadisplay | ||
| - python2-waitress | ||
| - python2-yaml | ||
| - python2-zmq |
There was a problem hiding this comment.
Out of curiosity, why do you need to directly depend on zmq? fedmsg should depend on it.
There was a problem hiding this comment.
I'm not sure why zmq is here, but I just tested the Vagrant box without it and it worked fine, so I'll drop it.
Cornice 2 requires pyramid >= 1.7 and Fedora 25 only has pyramid-1.5, so this commit also adjusts the Vagrantfile.example to use Fedora 26 by default instead of 25. re fedora-infra#1922 Signed-off-by: Randy Barlow <randy@electronsweatshop.com>
Cornice 2 requires pyramid >= 1.7 and Fedora 25 only has
pyramid-1.5, so this commit also adjusts the Vagrantfile.example
to use Fedora 26 by default instead of 25.
re #1922
Signed-off-by: Randy Barlow randy@electronsweatshop.com