Add Flatpak support #2526
Merged
Add Flatpak support #2526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bowlofeggs
suggested changes
Aug 16, 2018
bodhi/server/buildsys.py
Outdated
| @@ -261,6 +261,16 @@ def getBuild(self, build='TurboGears-1.0.2.2-2.fc17', other=False, testing=False | |||
| } | |||
| break | |||
|
|
|||
| if token.endswith("flatpak"): | |||
| tag = "f%s-updates-testing" % token.replace("fc", "").replace("", "") | |||
There was a problem hiding this comment.
Let's drop the replace() call if it's not needed.
| class FlatpakComposerThread(ContainerComposerThread): | ||
| """Use skopeo to copy and tag flatpak images.""" | ||
|
|
||
| ctype = ContentType.flatpak |
There was a problem hiding this comment.
Heh, looks like patching this file was pretty easy ☺
| @@ -1075,9 +1080,11 @@ def get_pkg_committers_from_pagure(self): | |||
| """ | |||
| pagure_url = config.get('pagure_url') | |||
| # Pagure uses plural names for its namespaces such as "rpms" except for | |||
| # container | |||
| # container. Flatpaks build directly from the 'modules' namespace | |||
There was a problem hiding this comment.
Ah, so I take this to mean that ACLs on a flatpak are identical to having ACLs to the module of the same name?
Add a new content type for flatpaks, which is inferred from the Koji metadata. Flatpaks are mashed exactly the same as containers - the content type is different mostly to get a non-confusing display of content type in the user interface and to allow future enhancements like Flatpak-specific testing instructions. Signed-off-by: Owen W. Taylor <otaylor@fishsoup.net>
bowlofeggs
approved these changes
Aug 16, 2018
|
These patches are planned to be included in the upcoming 3.10.0 release: #2556. |
|
These patches have been deployed to Fedora's staging Bodhi instance: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new content type for flatpaks, which is inferred from the Koji metadata.
Flatpaks are mashed exactly the same as containers - the content type is
different mostly to get a non-confusing display of content type in the user
interface and to allow future enhancements like Flatpak-specific testing
instructions.
Signed-off-by: Owen W. Taylor otaylor@fishsoup.net