Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use update.get_url() to generate comments url #2596

Merged
merged 3 commits into from Sep 19, 2018

Conversation

Projects
None yet
2 participants
@mattiaverga
Copy link
Contributor

commented Sep 14, 2018

Fixes #2574

Signed-off-by: Mattia Verga mattia.verga@tiscali.it

@mattiaverga mattiaverga requested a review from fedora-infra/bodhi as a code owner Sep 14, 2018

Use update.get_url() to generate comments url
Signed-off-by: Mattia Verga <mattia.verga@tiscali.it>

@bowlofeggs bowlofeggs force-pushed the mattiaverga:comments_links branch from 2b56571 to 8b613d6 Sep 17, 2018

@fedora-infra fedora-infra deleted a comment from centos-ci Sep 18, 2018

@bowlofeggs

This comment has been minimized.

Copy link
Member

commented Sep 18, 2018

I think the f28 unit test failure was due to https://bugs.centos.org/view.php?id=14920. I'll try to re-run again.

@bowlofeggs

This comment has been minimized.

Copy link
Member

commented Sep 18, 2018

Man, this CI thing is really crippling. I've run it so many times and each time one of them gets a dirty node :/

@fedora-infra fedora-infra deleted a comment from centos-ci Sep 19, 2018

@bowlofeggs

This comment has been minimized.

Copy link
Member

commented Sep 19, 2018

I'm going to manually merge this one since I can't get CI to pass.

@bowlofeggs bowlofeggs merged commit 3faf603 into fedora-infra:develop Sep 19, 2018

19 of 23 checks passed

docs tests (pip) Build finished.
Details
unit tests (pip) Build finished.
Details
unit tests (rawhide) Build finished.
Details
mergify/pr Waiting for status checks success
DCO DCO
Details
default Build finished.
Details
docs tests (f27) Build finished.
Details
docs tests (f28) Build finished.
Details
docs tests (f29) Build finished.
Details
docs tests (rawhide) Build finished.
Details
flake8 tests (f27) Build finished.
Details
flake8 tests (f28) Build finished.
Details
flake8 tests (f29) Build finished.
Details
flake8 tests (pip) Build finished.
Details
flake8 tests (rawhide) Build finished.
Details
pydocstyle tests (f27) Build finished.
Details
pydocstyle tests (f28) Build finished.
Details
pydocstyle tests (f29) Build finished.
Details
pydocstyle tests (pip) Build finished.
Details
pydocstyle tests (rawhide) Build finished.
Details
unit tests (f27) Build finished.
Details
unit tests (f28) Build finished.
Details
unit tests (f29) Build finished.
Details

@mattiaverga mattiaverga deleted the mattiaverga:comments_links branch Sep 26, 2018

@bowlofeggs

This comment has been minimized.

Copy link
Member

commented Nov 12, 2018

Bodhi 3.11.0b5 has been deployed to staging:

https://bodhi.stg.fedoraproject.org

It is also available via Copr:

https://copr.fedorainfracloud.org/coprs/bowlofeggs/bodhi-pre-release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.