Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for CVEs. #2915

Merged
merged 1 commit into from Feb 4, 2019
Merged

Drop support for CVEs. #2915

merged 1 commit into from Feb 4, 2019

Conversation

bowlofeggs
Copy link
Contributor

Bodhi has code to deal with CVEs, but it has never worked and was
not used. Since nobody has ever asked for it to work during my
tenure, I decided to trim it out of the code for now so we don't
have to maintain it.

fixes #1998

Signed-off-by: Randy Barlow randy@electronsweatshop.com

@bowlofeggs bowlofeggs added API Issues related to Bodhi's REST API Client Issues with the bodhi command line interface tool Migration Issues or pull requests that involve a database migration Refactor Issues that are a refactor to improve maintainability for Bodhi Backwards incompatible The proposed change is backwards incompatible and should wait for the next major release labels Jan 10, 2019
@bowlofeggs bowlofeggs added this to In progress in Release Bodhi 4.0.0 via automation Jan 10, 2019
@bowlofeggs bowlofeggs requested a review from a team as a code owner January 10, 2019 13:23
@bowlofeggs bowlofeggs moved this from In progress to Needs review in Release Bodhi 4.0.0 Jan 10, 2019
pypingou
pypingou approved these changes Jan 17, 2019
View reviewed changes
Copy link
Member

@pypingou pypingou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Less-code++

Release Bodhi 4.0.0 automation moved this from Needs review to Reviewer approved Jan 17, 2019
@bowlofeggs
Copy link
Contributor Author

I'm going to rebase this to fix the conflicts and hopefully get the tests to pass too.

@bowlofeggs
Copy link
Contributor Author

I am also applying this patch since another migration has since been added:

diff --git a/bodhi/server/migrations/versions/5c86a3f9dc03_drop_support_for_cve_tracking.py b/bodhi/server/migrations/versions/5c86a3f9dc03_drop_support_for_cve_tracking.py                                      
index 140c169a..66c670d4 100644
--- a/bodhi/server/migrations/versions/5c86a3f9dc03_drop_support_for_cve_tracking.py
+++ b/bodhi/server/migrations/versions/5c86a3f9dc03_drop_support_for_cve_tracking.py
@@ -28,7 +28,7 @@ import sqlalchemy as sa

 # revision identifiers, used by Alembic.
 revision = '5c86a3f9dc03'
-down_revision = '8e9dc57e082d'
+down_revision = 'a418acf470f8'


 def upgrade():

@bowlofeggs
Drop support for CVEs.
e71f443 
Bodhi has code to deal with CVEs, but it has never worked and was
not used. Since nobody has ever asked for it to work during my
tenure, I decided to trim it out of the code for now so we don't
have to maintain it.

fixes fedora-infra#1998

Signed-off-by: Randy Barlow <randy@electronsweatshop.com>
@bowlofeggs bowlofeggs merged commit e71f443 into fedora-infra:develop Feb 4, 2019
Release Bodhi 4.0.0 automation moved this from Reviewer approved to Done Feb 4, 2019
@bowlofeggs bowlofeggs deleted the 1998 branch February 4, 2019 21:30
@bowlofeggs
Copy link
Contributor Author

This patch is planned for inclusion in the upcoming 4.0.0 release: #3221

@bowlofeggs
Copy link
Contributor Author

Bodhi 4.0.0 beta is built and deployed to staging:

https://copr.fedorainfracloud.org/coprs/bowlofeggs/bodhi-pre-release
https://bodhi.stg.fedoraproject.org/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pypingou pypingou pypingou approved these changes

Assignees
No one assigned
Labels
API Issues related to Bodhi's REST API Backwards incompatible The proposed change is backwards incompatible and should wait for the next major release Client Issues with the bodhi command line interface tool Migration Issues or pull requests that involve a database migration Refactor Issues that are a refactor to improve maintainability for Bodhi
Projects
No open projects
Release Bodhi 4.0.0
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The CVE model seems to be unused
2 participants
@bowlofeggs @pypingou