Download database dumps first in CentOS CI #2981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, every run of the integration test suite would download a copy of the Fedora Infrastructure's database dumps. The infrastructure only produces a backup once a day, so this is inefficient for developers who work on Bodhi often. This commit adjusts it to only download the database dump if we don't have it already or if the copy we have is older than a day. Signed-off-by: Randy Barlow <randy@electronsweatshop.com>
bowlofeggs
added
High priority
Prior to this commit, if several bodhi-ci processes were run in parallel, each of them would download their own copy of the database dump. Currently this is how CentOS CI runs our tests, and this led to a problem where one process would overrwrite the file that another process was currently reading, which led to problems. This new command allows us to run a single process of bodhi-ci to download the integration test datatbase dumps before we fan out to many processes in CentOS CI. Combined with the prior commit that skips downloading recently modified files, we can now be sure that the fanned out processes in CentOS CI will not write files that others are reading, because they will all skip the download job now. Signed-off-by: Randy Barlow <randy@electronsweatshop.com>
bowlofeggs
force-pushed
the
bodhi-ci-dl_separately
branch
from
ead873e
to
966d706
Compare
abompard
reviewed
Feb 7, 2019
abompard
approved these changes
Feb 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two commits in this pull request, with detailed commit messages. The overall theme of this pull request is to make sure that database downloads only happen once, even when multiple bodhi-ci processes are run in CentOS CI.