Extend integration tests #3050
Extend integration tests #3050
Conversation
|
@bowlofeggs I'm not sure about the direction of this PR. My plan is to add new integration tests like:
The list of test cases can be long, so first I would like to know what do you think. |
|
+1, we definitely want to add a bunch of integration tests. To get write working, we need to set up an Ipsilon server in our CI suite. @puiterwijk told me that there's a way to configure Ipsilon to have a test user that sounded really easy and handy. So if we configure it that way, it should be pretty straightforward to start testing things like creating updates and editing updates. That would be very nice to have! |
sebwoj
force-pushed
the
Extend_integration_tests
branch
from
b758228
to
54292cb
Compare
| elif value == "logout": | ||
| assert "Logout Required" in http_response.text | ||
| else: | ||
| assert value in http_response.text |
There was a problem hiding this comment.
Instead of looping over the keys and values, why not assert the keys you expect directly?
There was a problem hiding this comment.
I'm not sure I understand. Do you think that it will be better to check for keys in http_response.text instead of values?
There was a problem hiding this comment.
I meant more to ask why we don't just expect the keys to be present and just make the above assertions, as opposed to the large if/else block. For example, why not do things like this instead:
if update_info['request']:
assert update_info['request'] in http_response.text
assert f"stable threshold: {update_info['stable_karma']}" in http_response.text
<etc>
There was a problem hiding this comment.
At first, my intention was just to loop over values and check existance(of raw value) in response, but I find out that most of update's fields are rendered different way than just raw value, so I started to adding more and more if/else statements. I will rewrite it.
| assert "Logout Required" in http_response.text | ||
| else: | ||
| assert value in http_response.text | ||
| # ffmarkdown... |
There was a problem hiding this comment.
| # ffmarkdown... |
There was a problem hiding this comment.
At first I wrote the assertions for comments, but I noticed that we sue "markdown" to create links in the middle of comment text. I decided to drop update's comment tests.
| else: | ||
| assert value in http_response.text | ||
| # ffmarkdown... | ||
| # for comment_text in expected_comments: |
There was a problem hiding this comment.
| # for comment_text in expected_comments: |
| assert value in http_response.text | ||
| # ffmarkdown... | ||
| # for comment_text in expected_comments: | ||
| # assert comment_text in http_response.text |
There was a problem hiding this comment.
| # assert comment_text in http_response.text |
sebwoj
force-pushed
the
Extend_integration_tests
branch
from
54292cb
to
f1578a4
Compare
sebwoj
force-pushed
the
Extend_integration_tests
branch
2 times, most recently
from
4f5a750
to
eec56f9
Compare
| @@ -1,4 +1,4 @@ | |||
| # Copyright © 2018 Red Hat, Inc. | |||
| # Copyright © 2019 Red Hat, Inc. | |||
There was a problem hiding this comment.
| # Copyright © 2019 Red Hat, Inc. | |
| # Copyright © 2018-2019 Red Hat, Inc. |
bowlofeggs
force-pushed
the
Extend_integration_tests
branch
3 times, most recently
from
144bbca
to
571e7fc
Compare
This commit adds a few new tests to integration tests. Such tests will prevent issues like fedora-infra#2966. This will increase overall integration test duration, but will also increase safety. Signed-off-by: Sebastian Wojciechowski <s.wojciechowski89@gmail.com>
bowlofeggs
force-pushed
the
Extend_integration_tests
branch
from
571e7fc
to
ef78e94
Compare
This commit adds a few new tests to integration tests. Such tests will prevent
issues like #2966. This will increase overall integration test duration, but will
also increase safety.
Signed-off-by: Sebastian Wojciechowski s.wojciechowski89@gmail.com