resultsdb/waiverdb: skip updating gating status if it's ignored #5202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamWill
force-pushed
the
consumers-ignored
branch
2 times, most recently
from
1ca7308
to
2ba3320
Compare
|
I don't think the failure is related to the PR: |
There's no point recalculating the gating status in response to a new result or a new waiver if the status is 'ignored', which means there are no requirements. Doing so just results in this kind of unnecessary pingpong: https://bodhi.fedoraproject.org/updates/FEDORA-2023-0e548f86e7 Signed-off-by: Adam Williamson <awilliam@redhat.com>
mattiaverga
force-pushed
the
consumers-ignored
branch
from
2ba3320
to
1fbc80d
Compare
mattiaverga
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no point recalculating the gating status in response to a new result or a new waiver if the status is 'ignored', which means there are no requirements. Doing so just results in this kind of unnecessary pingpong:
https://bodhi.fedoraproject.org/updates/FEDORA-2023-0e548f86e7